py/builtinimport.c: Refactor module importing. #8010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63c992b to
9606617
Compare
|
Bare-arm is +16 with this... I guess most of the savings on PYBV11 come from disabling the "-m" behaviour. Also appveyor fails, maybe because "-m" needs to be enabled on that port? |
e3d9fbc to
b0ab887
Compare
Simplify and document/comment the handling of builtin import for: - already-loaded modules - built-in modules - built-in umodules (formerly weak links) - filesystem modules Retains existing functionality with smaller code size but should also facilitate potential new features (built-in packages, controlling the frozen path). Also makes the (unix-only) -m behavior a bit more obvious. Code size reduction of 208 bytes on PYBV11.
b0ab887 to
89deb17
Compare
|
bare-arm is back to 0 now. Savings come from some small optimisations in the relative path resolving but yeah mostly the -m bit. Windows build is fixed -- this was a logic error in weak link handling that the uasyncio tests being skipped triggered. I will add a test for this. |
|
I double checked the coverage change locally, and there is no change to Code size diff is: |
|
Merged in a7fa18c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the refactor part of #5701 (but with more improvements).
Simplify and document/comment the handling of builtin import for:
Retains existing functionality with smaller code size but should also facilitate potential new features (built-in packages, controlling the frozen path).
Also makes the (unix-only) -m behavior a bit more obvious.
Code size reduction of 208 bytes on PYBV11.