Skip to content

windows/uasyncio: Add support for uasyncio to windows dev variant. #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

andrewleech
Copy link
Contributor

@andrewleech andrewleech commented Nov 25, 2021

This PR enables the micropython uselect module on the windows port to allow freezing uasyncio into the dev variant.

This is built on top of #7780 so includes the commits from there too because github doesn't give any way to declare / separate dependent PR's.

This does also require #7999 to be merged first

@andrewleech andrewleech force-pushed the windows_uasyncio branch 2 times, most recently from 4d356e8 to a4ac22a Compare November 25, 2021 03:14
@dpgeorge
Copy link
Member

@andrewleech can you please rebase this on latest master, now that all prerequisite PRs have been merged?

@dpgeorge
Copy link
Member

There's an error building the dev variant:

objmodule.obj : error LNK2001: unresolved external symbol _mp_module_uasyncio [C:\projects\micropython\ports\windows\micropython.vcxproj]
objmodule.obj : error LNK2001: unresolved external symbol _mp_module_uselect [C:\projects\micropython\ports\windows\micropython.vcxproj]

@dpgeorge
Copy link
Member

It just needs the relevant extmod files added to msvc/sources.props

@andrewleech
Copy link
Contributor Author

@dpgeorge I've fixed the last couple of issues here.

@dpgeorge dpgeorge merged commit 6f7d6c5 into micropython:master Feb 7, 2022
@dpgeorge
Copy link
Member

dpgeorge commented Feb 7, 2022

Thank you!

@andrewleech andrewleech deleted the windows_uasyncio branch February 7, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants