windows: msbuild variant support #8032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eac4dae to
f72a506
Compare
4725743 to
feb6170
Compare
The application isn't necessarily called 'micropython' especially not When using variants, i.e. the tests need to be ran using $(PROG).
This is the same fix as applied in uselect_poll_basic.py.
This makes sure changes from previous related commits actually work.
feb6170 to
e1bee0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7780 from @andrewleech so shouldn't be merged until that one is in (note I needed the 'Remove extension from $(PROG) commit' because otherwise PROG becomes micropython.exe.exe).
I sticked to the convention of prefixing msbuild properties with
Py(which is done to avoid possible name clashes because there are quite a lot of builtin properties already) so it'sPyVariant=devnotVARIANT=dev. Should be ok I think, the README makes it clear.In principle it's possible to also run the tests for the msvc port through the project file (like the change made for running tests via the Makefile) but that's just more work with not much benefit.