Skip to content

esp32\machine_pwm.c: HOTFIX PWM duty. #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

IhorNehrutsa
Copy link
Contributor

@IhorNehrutsa IhorNehrutsa commented Dec 10, 2021

Save the same duty cycle when frequency (or frequency resolution) is changed.

The bug is detected with Example of a smooth frequency change from https://docs.micropython.org/en/latest/esp32/tutorial/pwm.html

dpgeorge
dpgeorge previously approved these changes Dec 15, 2021
@dpgeorge dpgeorge dismissed their stale review December 15, 2021 01:02

found mistake

@dpgeorge
Copy link
Member

Merged in 09fe80d

@dpgeorge dpgeorge closed this Dec 21, 2021
@IhorNehrutsa IhorNehrutsa deleted the HOTFIX_esp32_PWM_duty branch December 29, 2021 08:18
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jun 8, 2023
…rease-contrast

Update badger2040 start sequence for more contrast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants