esp32/machine_bitstream: Reinstate bit-bang implementation. #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment moved to #8161 |
|
The glitching should be properly fixed by #8170, which puts RMT on core 1. Regardless, I still think this PR is useful. |
The bit-bang implementation was replaced with the RMT implementation in 599b61c. This commit brings back that bit-bang code, and allows it to be selected via the new static method: esp32.RMT.bitstream_channel(None) The bit-bang implementation may be useful if the RMT needs to be used for something else, or if bit-banging is more stable in certain applications. Signed-off-by: Damien George <damien@micropython.org>
f6bf94b to
a3bbd53
Compare
|
Merged, but the default stays as RMT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new esp32 bitstream/neopixel driver based on RMT can have glitches when WiFi is enabled. It's not currently known why this happens, but for now here is a patch which reinstates the previous bit-bang implementation.
It's now possible to select bit-bang or RMT via:
The default is to use bit-banging.