Skip to content

ports: Consolidate include of umachine module in built-ins. #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dpgeorge
Copy link
Member

@dpgeorge dpgeorge commented Feb 2, 2022

The inclusion of umachine in the list of built-in modules is now done centrally in py/objmodule.c. Enabling MICROPY_PY_MACHINE will include this module.

As part of this, all ports now have umachine as the core module name (previously some had only machine as the name).

Addresses #8241.

@dpgeorge dpgeorge added the ports Relates to multiple ports, or a new/proposed port label Feb 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #8244 (fbd47fc) into master (102cc12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8244   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         153      153           
  Lines       20145    20145           
=======================================
  Hits        19838    19838           
  Misses        307      307           
Impacted Files Coverage Δ
py/objmodule.c 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102cc12...fbd47fc. Read the comment docs.

The inclusion of `umachine` in the list of built-in modules is now done
centrally in py/objmodule.c.  Enabling MICROPY_PY_MACHINE will include this
module.

As part of this, all ports now have `umachine` as the core module name
(previously some had only `machine` as the name).

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the ports-consolidate-umachine-name branch from 66831d3 to fbd47fc Compare February 2, 2022 23:09
@dpgeorge dpgeorge merged commit fbd47fc into micropython:master Feb 2, 2022
@dpgeorge dpgeorge deleted the ports-consolidate-umachine-name branch February 2, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ports Relates to multiple ports, or a new/proposed port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants