rp2/boards: Add WEACTSTUDIO boards with BOARD_VARIANT to select the flash size #8505
Conversation
d1dbaa3 to
9250907
Compare
|
I thought Wavgat was more of a reseller than a board fab. The form factor reminds me of a WeAct back-pill board, eg: https://www.aliexpress.com/item/1005003658370449.html Found it on TaoBao: https://item.taobao.com/item.htm?id=671510282412 and https://item.taobao.com/item.htm?id=665800371434 It's a WeAct board. Why don't they put labels on them! |
|
... they do
Looks like this Wavgat board is a clone. In their back side of the board image you can see where they blacked out the WeAct logo:
|
So should I rename the board to WeAct? WeActStudio? Any suggestions? |
|
OK, renamed to WeAct Studio RP2040. Thanks @mcauser! |
|
FWIW, I'm currently seeing a build error with this PR: Note that I'm a n00b at building my own firmwares so this could be user error, but I've successfully built a base rp2040, and also a |
f80790e to
47d4267
Compare
|
Rebased and tidied up. It would be good to support the different storage options; should this be done with an optional build parameter? Is there any precedent for this? It doesn't seem to make sense to have completely separate board definitions when the only thing that changes is the flash size... |
9bea805 to
a7b9cbd
Compare
Codecov Report
@@ Coverage Diff @@
## master #8505 +/- ##
==========================================
+ Coverage 98.37% 98.38% +0.01%
==========================================
Files 156 156
Lines 20443 20477 +34
==========================================
+ Hits 20110 20147 +37
+ Misses 333 330 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
822c081 to
40632dd
Compare
Following stm32. This allows a single board definition to define variants of its configuration.
This supports 2, 4, 8 and 16MB flash variants.
8f16067 to
bdbc444
Compare
|
I reorganised the commits into two separate ones and force pushed to this PR's branch. The code is unchanged. |
…nterrupt Fixed the RP2040 interrupt problem
This is adding a board definition for the Wavgat Pico Board RP2040. This is for the 16MB version; once this PR is in good shape I'll create the 2/4/8 MB versions too.
Note that
lib/mbedtlshas been added as a submodule; this has nothing to do with this board - it appears to be necessary for the rp2 port?Also of note: I'm not aware of any VID/PID for the Wavgat boards so I left these defines out. It seems to work but I'm not sure that's the right thing to do...?
Finally, it was somewhat unexpected that pico-sdk typically has definitions for each supported board. This is the first MicroPython example of a board that is defined outside of the pico-sdk repository (by specifying
PICO_BOARD_HEADER_DIRSand creatingwavgat_16mb.hlocally).