py/modmath: New function math hypot. #8593
Open
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Apr 28, 2022
| ans = (mp_float_t)0.0; | ||
| for (size_t i = 0; i < n_args; i++) { | ||
| a = mp_obj_get_float(args[i]); | ||
| a_pow2 = MICROPY_FLOAT_C_FUN(pow)(a, 2); |
There was a problem hiding this comment.
Would it be more efficient to just do ans += a * a instead of calling pow?
dlech
reviewed
Apr 29, 2022
| (), | ||
| (1.5, 1.5, 0.5), | ||
| (1.5, 0.5, 1.5), | ||
| ), |
There was a problem hiding this comment.
Should we add tests for NaN and infinity arguments and return values?
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the math.hypot function.
This implementation covers the Change in CPython 3.8, Multidimensional support of math.hypot(). python/cpython#8474
This was worked on with the assistance of @wang3450