Improve sys.settrace to help support bdb/pdb debugging #8767

andrewleech · 2022-06-16T23:48:37Z

Companion support for micropython/micropython-lib#499

Requires micropython be built with MICROPY_PY_SYS_SETTRACE eg. unix dev variant

Includes:

sys/settrace: Add sys._getframe() function.
Refer to https://docs.python.org/3/library/sys.html#sys._getframe
sys/settrace: Add frame.f_trace object support.
f_trace holds a python obj on the frame, used in bdb to track active trace function for call stack.

codecov-commenter · 2022-06-20T00:09:22Z

Codecov Report

Merging #8767 (e027113) into master (d7919ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8767   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         156      156           
  Lines       20326    20326           
=======================================
  Hits        19983    19983           
  Misses        343      343

Impacted Files	Coverage Δ
py/modsys.c	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7919ea...e027113. Read the comment docs.

Requires micropython/micropython#8767

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

dpgeorge · 2022-06-27T02:24:27Z

py/modsys.c

+MP_DEFINE_CONST_FUN_OBJ_0(mp_sys_gettrace_obj, mp_sys_gettrace);
+
+// _getframe(): Return current frame object.
+STATIC mp_obj_t mp_sys_getframe(size_t n_args, const mp_obj_t *args) {


please call it mp_sys__getframe

dpgeorge · 2022-06-27T02:26:22Z

py/objfun.c

+    if (attr == MP_QSTR___code__) {
+        mp_obj_fun_bc_t *self = MP_OBJ_TO_PTR(self_in);
+        mp_obj_code_t *code = MP_OBJ_TO_PTR(mp_obj_new_code(self->context, self->rc));
+        if (code != NULL) {


can code be null?

dpgeorge · 2022-06-27T02:32:04Z

py/profile.c

    switch (attr) {
        case MP_QSTR_f_back:
            dest[0] = mp_const_none;
            if (o->code_state->prev_state) {
+                if (!o->code_state->prev_state->frame) {


did you find a case where this could be NULL? maybe it needs a test...

dpgeorge · 2022-06-27T02:33:24Z

py/profile.c

+            dest[0] = o->trace_obj;
+            break;
+        case MP_QSTR_f_locals:
+            dest[0] = MP_OBJ_FROM_PTR(o->code->dict_locals);


is this needed? locals in uPy doesn't work well

can we just return an empty dict instead?

dpgeorge · 2022-06-27T02:33:58Z

py/profile.c

@@ -274,6 +292,7 @@ mp_obj_t mp_obj_new_frame(const mp_code_state_t *code_state) {
    o->lineno = mp_prof_bytecode_lineno(rc, o->lasti);
    o->trace_opcodes = false;
    o->callback = MP_OBJ_NULL;
+    o->trace_obj = MP_OBJ_NULL;


maybe call it f_trace

dpgeorge · 2022-06-27T02:35:11Z

py/profile.h

@@ -60,7 +61,9 @@ mp_obj_t mp_obj_new_frame(const mp_code_state_t *code_state);

 // This is the implementation for the sys.settrace
 mp_obj_t mp_prof_settrace(mp_obj_t callback);
+mp_obj_t mp_prof_gettrace();


please put void in arg list

dpgeorge · 2022-06-27T02:35:58Z

py/profile.c

@@ -313,6 +332,33 @@ mp_obj_t mp_prof_settrace(mp_obj_t callback) {
    return mp_const_none;
 }

+mp_obj_t mp_prof_gettrace() {


void in arg list

dpgeorge · 2022-06-27T02:38:19Z

py/profile.c

+    return prof_trace_cb;
+}
+
+mp_obj_t mp_prof_get_frame(int depth) {


can we change int to size_t to indicate it can't be negative?

Only if MICROPY_PY_SYS_SETTRACE is enabled. This is used to provide introspection of attributes such as function name or source file & line. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>

Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>

Refer to https://docs.python.org/3/library/sys.html#sys._getframe

Used in bdb.py debugging support.

Refer to https://docs.python.org/3/library/sys.html#sys.gettrace

Used in pdb.py debugging support.

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

github-actions · 2023-08-24T01:07:00Z

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64: +26848 +3.362% standard[incl +9056(data) +24(bss)]
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40

Re-enable binascii.crc32()

projectgus · 2024-03-07T23:51:51Z

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

andrewleech force-pushed the pdb_support branch 2 times, most recently from 16bd204 to e027113 Compare June 19, 2022 23:51

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Jun 20, 2022

bdb: Re-enable usage of frame.f_trace.

c1d415b

Requires micropython/micropython#8767

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Jun 20, 2022

bdb: Re-enable usage of frame.f_trace.

c03abd8

Requires micropython/micropython#8767

andrewleech mentioned this pull request Jun 21, 2022

Draft: Working towards pdb debugging support. micropython/micropython-lib#499

Open

andrewleech force-pushed the pdb_support branch from e027113 to f3c6bf2 Compare June 22, 2022 00:37

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Jun 22, 2022

bdb: Add initial micropython support.

b690b51

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Jun 22, 2022

bdb: Add initial micropython support.

6f5221d

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Jun 22, 2022

bdb: Add initial micropython support.

da52b43

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

dpgeorge reviewed Jun 27, 2022

View reviewed changes

dpgeorge added the py-core Relates to py/ directory in source label Jun 29, 2022

dpgeorge changed the title ~~Draft: Working towards pdb debugging support.~~ Improve sys.settrace support to help support bdb/pdb debugging Jun 29, 2022

dpgeorge changed the title ~~Improve sys.settrace support to help support bdb/pdb debugging~~ Improve sys.settrace to help support bdb/pdb debugging Jun 29, 2022

rkompass mentioned this pull request Dec 27, 2022

m.iMX RT: After a few seconds print() hangs #10335

Closed

pi-anl added 7 commits August 22, 2023 09:09

py/objfun: Add function.__code__ attribute.

837447a

Only if MICROPY_PY_SYS_SETTRACE is enabled. This is used to provide introspection of attributes such as function name or source file & line. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>

py/profile: Add __code__.co_varnames to query function arguments.

72dfbde

Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>

unix/standard: Enable sys.settrace() by default.

2218fe9

Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>

sys/settrace: Add sys._getframe() function.

3d904f7

Refer to https://docs.python.org/3/library/sys.html#sys._getframe

sys/settrace: Add frame.f_trace object support.

82a9a26

Used in bdb.py debugging support.

sys/gettrace: Add gettrace function to mirror settrace.

1c58bbb

Refer to https://docs.python.org/3/library/sys.html#sys.gettrace

sys/settrace: Add frame.f_locals placeholder.

c32fec4

Used in pdb.py debugging support.

andrewleech pushed a commit to andrewleech/micropython-lib that referenced this pull request Aug 24, 2023

bdb: Add initial micropython support.

448c386

Requires micropython to be compiled with MICROPY_PY_SYS_SETTRACE. Also requires micropython/micropython#8767

andrewleech force-pushed the pdb_support branch from f3c6bf2 to c32fec4 Compare August 24, 2023 00:57

RetiredWizard pushed a commit to RetiredWizard/micropython that referenced this pull request Dec 30, 2023

Merge pull request micropython#8767 from dhalbert/turn-on-crc32

1d13364

Re-enable binascii.crc32()

Gadgetoid mentioned this pull request Feb 29, 2024

global: Remove the STATIC macro. #13763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve sys.settrace to help support bdb/pdb debugging #8767

Improve sys.settrace to help support bdb/pdb debugging #8767

andrewleech commented Jun 16, 2022 •

edited

Loading

codecov-commenter commented Jun 20, 2022 •

edited

Loading

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

dpgeorge Jun 27, 2022

github-actions bot commented Aug 24, 2023

projectgus commented Mar 7, 2024

Improve sys.settrace to help support bdb/pdb debugging #8767

Are you sure you want to change the base?

Improve sys.settrace to help support bdb/pdb debugging #8767

Conversation

andrewleech commented Jun 16, 2022 • edited Loading

codecov-commenter commented Jun 20, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 24, 2023

projectgus commented Mar 7, 2024

andrewleech commented Jun 16, 2022 •

edited

Loading

codecov-commenter commented Jun 20, 2022 •

edited

Loading