Skip to content

esp32: Use check_esp_err() for get error message. #8830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

esp32: Use check_esp_err() for get error message. #8830

wants to merge 1 commit into from

Conversation

IhorNehrutsa
Copy link
Contributor

I suggest making the path to understanding the error easier.

First, all esp-idf errors will have native error messages. For example:
ESP_ERR_ESP_NETIF_DNS_NOT_CONFIGURED will be output, not
Wifi Unknown Error 0x500A

Second, ESP_ERR_XXX_XXX error codes have more info in Google search requests.

@MATTYGILO
Copy link

Same problem

@IhorNehrutsa IhorNehrutsa force-pushed the esp_exceptions_helper branch 2 times, most recently from ff6669d to 609115a Compare July 21, 2023 13:34
@IhorNehrutsa
Copy link
Contributor Author

@robert-hh
May you review this PR?
Thanks

@robert-hh
Copy link
Contributor

That PR seems useful for all users, and there is no change in code size. Looks good.

@IhorNehrutsa
Copy link
Contributor Author

@dpgeorge
May add to the https://github.com/micropython/micropython/milestone/4 ?

@IhorNehrutsa IhorNehrutsa force-pushed the esp_exceptions_helper branch from c0a004c to 6f066e0 Compare August 10, 2023 13:42
@IhorNehrutsa
esp32: Use esp_err_to_name() to get error message.
1202fe1 
doc/esp32/quickref.rst: Add Error handling.

esp32/network_common.c: Use esp_err_to_name() to get error message.

Signed-off-by: IhorNehrutsa <Ihor.Nehrutsa@gmail.com>
@IhorNehrutsa
Copy link
Contributor Author

Closed in favor #10888

tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Jan 30, 2024
@dhalbert
Merge pull request micropython#8830 from dhalbert/hid-wakeup
370b011 
shared-module/usb_hid: allow HID to wake sleeping host computer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MATTYGILO MATTYGILO MATTYGILO approved these changes

Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IhorNehrutsa @MATTYGILO @robert-hh @dpgeorge