py/_thread: Add support for lock.acquire timeout. #8932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This working on micropython/micropython-lib#503 I ran into the limitation that while the
_thread.Lock.acquire()
function supports thewaitflag
argument, it doesn't handle thetimeout
arg - while you can pass it it's silently ignored and instead blocks forever.This PR adds support for the
timeout
arg. It does so in a fairly naive way I feel... but it does work.Ref: https://docs.python.org/3/library/_thread.html#thread.lock.acquire
Similarly the test is not exactly best practice, what with having a static sleep in the middle, but it does test the behaviour.