-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
stm32: Use lib/wiznet5k instead of drivers/wiznet5k. #9019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the first step. The code compiles.
The object retuned for pyb.spi is not changed. This function is also used for the cc3300 support.
- Register nic when the LWIP stack is used. That was missing, and network.route() returned an empty list. - Drop an obsolete argument check. The proper checks are done further down in the code. - Deinit the nic before (re-)initialisation. If nic.active(True) is called several times in a row, the device may lock up. Even if that is bad coding practice, calling wiznet5k_deinit() in wiznet5k_init() prevents the lock. - Check for the absence of keyword arguments. Using keyword arguments raises an error now. - Schedule clearing of interrupt flags. Avoiding conflicts between the IRQ and an active transfers. Before the change, the device could lock up in heavy traffic situations. Fix found and code supplied by @omogenot. - Rearrange the function wiznet5k_poll(). To have just one exit and a more compact flag test. This is just a style change without impact to the function. - Clear interrupt for W5100S.
@robert-hh
in |
There's already a conditional |
I propose to do a conditional
It might not be an obvious workaround if someone reads the makefile in the future, but I kind of remember that you told me that this CC3K was obsolete, no? |
No. That does not help. It looks like the problem is in ci.sh. The respective section is below:
If I run the line |
I'll close that for now to do a silent test for ci.sh changes. |
Apparently the main issues are:
I will try to do a Edit: No chance. It's a matter of include path precedence... Impossible to solve without, as you said, prevent make call with multiple network drivers. By the way, the |
I have a proper set-up, ci passes. I'm just cleaning it now and run a further test. |
I changed ci.sh in splitting the builds for wiznet5k and cc3k. But to be safe, I opened a new PR. I could not tell that after re-opening all commits were included. |
…03-07 update frozen libraries for 9.0.0-rc.0
This PR uses lib/wiznet5k instead of drivers/wiznet5k, like the rp2040 port already does. The change was initiated by @omogenot, and I picked up the baton for test, bug fixing and completion. See the thread at issue #9013. I tested the code change with a Wiznet W5500 breakout, with and without LWIP support. The performance is equivalent to the W5500 support for RP2040.
Two notes: