extmod/moduhashlib.c: Add block_size/digest_size. #9030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used by the hmac library in micropython-lib. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
|
See micropython/micropython-lib#515 which updates micropython-lib's |
|
Since this isn't strictly needed, let's hold out on it for now. If/when we have hashing algos that have a block size different to 64 then we can add the |
RetiredWizard
pushed a commit
to RetiredWizard/micropython
that referenced
this pull request
Mar 14, 2024
Add lolin s3 pro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used by the hmac library in micropython-lib, and are necessary for correct calculation/padding of the key.
Technically this PR isn't strictly necessary because the hmac library only needs
block_size, and furthermore because they're 64 for all the supported built-in hash functions it can make a sensible default. If we ever added a sha512 to hashlib then we would need this.