Skip to content

top: Update all manifest.py files to use new features from #8914. #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jimmo
Copy link
Member

@jimmo jimmo commented Aug 10, 2022

This is split out of #8914 so that required change from micropython-lib (micropython/micropython-lib#506, which depends on #8914) can be merged first, then the submodule updated.

  • Includes now use the directory path where possible (no longer necessary
    to include the manifest.py file explicitly).
  • Add manifest.py for all drivers and components that are referenced by
    port/board manifests.
  • Replace all uses of freeze() with package()/module(), except for port and
    board modules.
  • Use opt=3 everywhere.
  • Use require() instead of include() for all micropython-lib references.
  • Also reinstates modules that were accidentally removed from the esp8266
    512k build in fbe9417. (see https://github.com/micropython/micropython/pull/8854/files#r942342144)

- Includes now use the directory path where possible (no longer necessary
  to include the manifest.py file explicitly).
- Add manifest.py for all drivers and components that are referenced by
  port/board manifests.
- Replace all uses of freeze() with package()/module(), except for port and
  board modules.
- Use opt=3 everywhere.
- Use require() instead of include() for all micropython-lib references.
- Also reinstates modules that were accidentally removed from the esp8266
  512k build in fbe9417.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
@jimmo
Copy link
Member Author

jimmo commented Aug 10, 2022

(All the CI fails of course because it depends on #8914 and micropython/micropython-lib#506 )

@dpgeorge
Copy link
Member

dpgeorge commented Sep 5, 2022

Both dependencies of this PR have now been merged.

@dpgeorge
Copy link
Member

dpgeorge commented Sep 5, 2022

Rebased and merged in 203dae4 (micropython-lib submodule updated in prior commit ccd2109)

@dpgeorge dpgeorge closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants