Add some definition files for waveshare board. #9085

EngineerWill · 2022-08-22T09:31:31Z

Add some Waveshare board descriptions，like：

robert-hh · 2022-08-22T09:37:55Z

Two files not related to the new RP2040 boards sneaked into that commit. These are from a different already merged PR. So please remove them from your PR.

EngineerWill · 2022-08-22T09:47:39Z

Two files not related to the new RP2040 boards sneaked into that commit. These are from a different already merged PR. So please remove them from your PR.
Okay, let me google how do I remove them from my PR. Wait a minute

Flipje1955 · 2023-05-31T20:36:07Z

I try to understand the situation wrt Waveshare Zero (have a couple of them). This board is mentioned in this ticket as well as in #10314 and #9321. Yet, there is no download option for Waveshare boards on the download page which may be related to the status OPEN.
May I kindly ask if that is still an intention( as the ticket has not seen any (visible) attention since some time).
Thx !

EngineerWill · 2023-06-01T06:15:59Z

Although I don't quite understand, for some reason, it hasn't been merged yet, so I've been waiting.

I try to understand the situation wrt Waveshare Zero (have a couple of them). This board is mentioned in this ticket as well as in #10314 and #9321. Yet, there is no download option for Waveshare boards on the download page which may be related to the status OPEN. May I kindly ask if that is still an intention( as the ticket has not seen any (visible) attention since some time). Thx !

Flipje1955 · 2023-06-01T09:06:46Z

Thank you for your quick response. As you appear to be the driving force behind this pull request, will you then try to break the "waiting for some unknown" situation ?
(You carry "engineer" in your name; for me an engineer is typically interested in why things work or why they don't).

EngineerWill · 2023-06-01T10:45:45Z

Maybe MicroPython doesn't consider this pull request to be important, as it doesn't concern fixing any critical bugs or urgent issues. It appears that MicroPython merges pull requests in a sequential manner, and other reasons for non-merging might need to be addressed by MicroPython management.

I am an embedded engineer and this is my profession.I like it.so I call myself EngineerWill.

Thank you for your quick response. As you appear to be the driving force behind this pull request, will you then try to break the "waiting for some unknown" situation ? (You carry "engineer" in your name; for me an engineer is typically interested in why things work or why they don't).

TheChymera · 2023-06-01T17:35:43Z

This would be really great, I've had issues getting the waveshare RP2040-Zero boards to work since none of the firmware from the micropython website seem to work.

Took me a while to find working firmware (I initially thought the boards were just broken), from the manufacturer website, which, however, seems pretty outdated and also needs unzipping for some reason https://www.waveshare.com/w/upload/b/b4/Rp2-pico-w-20230219-unstable-v1.19.1.uf2.zip

Is there perhaps already something from the micropython website I can use? Closest I found was https://micropython.org/download/rp2-pico-w//resources/firmware/rp2-pico-w-20230426-v1.20.0.uf2 , which fails with:

GPIO test

GPIO connet to GND :  16 ,

GPIO connet to VCC :

GPIO connet to GPIO :

GPIO not connet : 0,9,10,11,12,13,14,15,26,


ADC test

GPIO28=0.53 V
GPIO28 adc Error!!!!!!
GPIO29=0.56 V
GPIO29 adc Error!!!!!!

Flipje1955 · 2023-06-01T19:55:55Z

Am puzzled by what you report on your experience with MP on Waveshare Zero. I am using the regular Pico firmware on the Waveshare board (now using: MicroPython v1.20.0-24-g867e4dd3d on 2023-04-27; Raspberry Pi Pico with RP2040) and that works (however, GPIO29 does not and I have not troubled to solder connections at the bottom-side as I can run my project with the pins availabe on the top side). So I cannot state I know for sure everything works.
You reference firmware for the Pico_W; as far as I know there is no Waveshare rp2040 with WIFI. Or is there ?

EngineerWill · 2023-06-02T01:06:40Z

Hello, according to the log you provided, it seems that you provided the RP2040-Zero factory program which is only used to test the RP2040-Zero hardware and needs to be used with the corresponding testing tool.

However, based on your description, it seems that you were unable to successfully flash the mpy firmware. Please note that RP2040-Zero is compatible with pico firmware, and you can obtain the corresponding firmware file on the Raspberry Pi official website.
Pico mpy firmware

This would be really great, I've had issues getting the waveshare RP2040-Zero boards to work since none of the firmware from the micropython website seem to work.

Took me a while to find working firmware (I initially thought the boards were just broken), from the manufacturer website, which, however, seems pretty outdated and also needs unzipping for some reason https://www.waveshare.com/w/upload/b/b4/Rp2-pico-w-20230219-unstable-v1.19.1.uf2.zip

Is there perhaps already something from the micropython website I can use? Closest I found was https://micropython.org/download/rp2-pico-w//resources/firmware/rp2-pico-w-20230426-v1.20.0.uf2 , which fails with:
GPIO test

GPIO connet to GND :  16 ,

GPIO connet to VCC :

GPIO connet to GPIO :

GPIO not connet : 0,9,10,11,12,13,14,15,26,


ADC test

GPIO28=0.53 V
GPIO28 adc Error!!!!!!
GPIO29=0.56 V
GPIO29 adc Error!!!!!!

codecov · 2023-10-17T07:28:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (5b4a2ba) to head (dac54d9).
Report is 558 commits behind head on master.

❗ Current head dac54d9 differs from pull request most recent head 3946cf5. Consider uploading reports for the commit 3946cf5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9085      +/-   ##
==========================================
- Coverage   98.39%   98.37%   -0.03%     
==========================================
  Files         158      156       -2     
  Lines       20965    20424     -541     
==========================================
- Hits        20629    20092     -537     
+ Misses        336      332       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

karlp · 2023-10-20T11:36:50Z

ports/rp2/boards/WAVESHARE_RP2040_LCD_0_96/mpconfigboard.h

+// url   :   https://www.waveshare.com/product/rp2040-lcd-0.96.htm
+// wiki  :   https://www.waveshare.com/wiki/RP2040-LCD-0.96
+//  Board and hardware specific configuration
+#define MICROPY_HW_BOARD_NAME "Waveshar RP2040-LCD-0.96"


typo in waveshare?

karlp · 2023-10-20T11:37:12Z

ports/rp2/boards/WAVESHARE_RP2040_LCD_0_96/board.json

+        "USB-C"
+    ],
+    "images": [
+        "rp2040-lcd-0.96-1.jpg"


this image is not provided in this PR?

Board images are intended to be submitted as a separate PR on the micropython-media repo, they're not included in this main repo to keep the size down.

image is provided in this PR(micropython/micropython-media#62)

karlp · 2023-10-20T11:37:50Z

ports/rp2/boards/WAVESHARE_RP2040_PLUS_16MB/board.json

+        "rp2040-plus-1.jpg"
+    ],
+    "mcu": "rp2040",
+    "product": "Waveshare RP2040=Plus",


typo in product name?

karlp · 2023-10-20T11:38:11Z

ports/rp2/boards/WAVESHARE_RP2040_PLUS_16MB/mpconfigboard.h

+// url   :   https://www.waveshare.com/product/rp2040-plus.htm
+// wiki  :   https://www.waveshare.com/wiki/RP2040-Plus
+//  Board and hardware specific configuration
+#define MICROPY_HW_BOARD_NAME "Waveshar RP2040-Plus"


typo in waveshare again?

karlp · 2023-10-20T11:38:35Z

ports/rp2/boards/WAVESHARE_RP2040_PLUS_16MB/mpconfigboard.h

+#define MICROPY_HW_USB_VID (0x2E8A)
+#define MICROPY_HW_USB_PID (0x1020)
+
+// user led gpio25


should this go in a pins.csv? there's no point in just having a dangling comment

karlp · 2023-10-20T11:38:54Z

ports/rp2/boards/WAVESHARE_RP2040_PLUS_4MB/mpconfigboard.h

+// url   :   https://www.waveshare.com/product/rp2040-plus.htm
+// wiki  :   https://www.waveshare.com/wiki/RP2040-Plus
+//  Board and hardware specific configuration
+#define MICROPY_HW_BOARD_NAME "Waveshar RP2040-Plus"


same typo again

karlp · 2023-10-20T11:39:05Z

ports/rp2/boards/WAVESHARE_RP2040_PLUS_4MB/mpconfigboard.h

+#define MICROPY_HW_USB_VID (0x2E8A)
+#define MICROPY_HW_USB_PID (0x1020)
+
+// user led gpio25


same comment on dangling comment vs pins.csv

karlp · 2023-10-20T11:39:20Z

ports/rp2/boards/WAVESHARE_RP2040_ZERO/mpconfigboard.h

+// url   :   https://www.waveshare.com/product/rp2040-zero.htm
+// wiki  :   http://www.waveshare.com/wiki/RP2040-Zero
+//  Board and hardware specific configuration
+#define MICROPY_HW_BOARD_NAME "Waveshar RP2040-Zero"


Signed-off-by: EngWill <646689853@qq.com>

mungewell · 2024-03-07T16:06:53Z

Some recent discussions with WaveShare support pointed me at this merge request, is there a reason it has not been done?

My (mis-)adventures with changing the XTALs on board for more precision parts will required a custom build, should the XTAL freq change. I have proved this on Ri-P boards, but the WaveShare boards are tempting me with a good price and include variant with an on-board LCD.

mungewell · 2024-03-28T15:40:40Z

@karlp @EngineerWill

Ping. Is there a reason this PR is not yet implemented?

EngineerWill · 2024-04-01T02:21:01Z

@karlp @EngineerWill

Ping. Is there a reason this PR is not yet implemented?

I don’t know why this PR hasn’t been processed yet

andrewleech · 2024-04-01T10:07:02Z

Actually, the two "plus" boards should now be implemented as two variants on the one board profile. To be fair the variant system didn't exist when you first put this merge request together.

An example of variant definitions can be seen in https://github.com/micropython/micropython/pull/12281/files

EngineerWill · 2024-04-01T10:20:51Z

Actually, the two "plus" boards should now be implemented as two variants on the one board profile. To be fair the variant system didn't exist when you first put this merge request together.

An example of variant definitions can be seen in https://github.com/micropython/micropython/pull/12281/files

I referred to the definition of ports/rp2/boards/PIMORONI_PICOLIPO_16MB and ports/rp2/boards/PIMORONI_PICOLIPO_4MB at that time

Do I need to modify it? If it needs to be modified, can you provide a reference case, because I think other rp2040 boards still have this problem.(like 'PIMORONI_PICOLIPO')

andrewleech · 2024-04-01T15:58:11Z

Ah interesting, yeah that board is an apt comparison. I'm not sure how the maintainers feel about the variants as a must, I thought existing cases like the pimoroni ones had been "cleaned up" already.

github-actions · 2024-12-23T06:36:10Z

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

EngineerWill force-pushed the Waveshare_Board branch 2 times, most recently from 4689d1e to ef518cb Compare August 22, 2022 10:05

dpgeorge added the port-rp2 label Aug 25, 2022

RetiredWizard mentioned this pull request Jan 26, 2023

rp2/boards: Add Waveshare rp2040 plus #10314

Open

jimmo added the board-definition New or updated board definition files. Combine with a port- label. label Oct 9, 2023

EngineerWill force-pushed the Waveshare_Board branch 2 times, most recently from 19b0858 to 0de9fa0 Compare October 17, 2023 10:20

karlp reviewed Oct 20, 2023

View reviewed changes

EngineerWill force-pushed the Waveshare_Board branch 2 times, most recently from 56d4194 to 20f3bb6 Compare October 26, 2023 04:03

ports/rp2/boards: Add some definition files for waveshare board.

3946cf5

Signed-off-by: EngWill <646689853@qq.com>

EngineerWill force-pushed the Waveshare_Board branch from 20f3bb6 to 3946cf5 Compare October 26, 2023 05:49

EngineerWill mentioned this pull request Apr 1, 2024

boards:Add Waveshare Board images micropython/micropython-media#62

Open

andrewleech added the maintainer-queue label Apr 1, 2024

andrewleech mentioned this pull request Apr 1, 2024

Add board definition for Waveshare RP2040-Zero. #13313

Open

andrewleech removed the maintainer-queue label Apr 1, 2024

mattytrentini mentioned this pull request Oct 31, 2024

Add Waveshare RP2040-Zero image. micropython/micropython-media#72

Open

Merge branch 'micropython:master' into Waveshare_Board

3924219

Josverl mentioned this pull request Mar 6, 2025

Add the WAVESHARE_RP2040_ZERO #16867

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some definition files for waveshare board. #9085

Add some definition files for waveshare board. #9085

EngineerWill commented Aug 22, 2022

robert-hh commented Aug 22, 2022

EngineerWill commented Aug 22, 2022

Flipje1955 commented May 31, 2023

EngineerWill commented Jun 1, 2023

Flipje1955 commented Jun 1, 2023

EngineerWill commented Jun 1, 2023

TheChymera commented Jun 1, 2023 •

edited

Loading

Flipje1955 commented Jun 1, 2023

EngineerWill commented Jun 2, 2023 •

edited

Loading

codecov bot commented Oct 17, 2023 •

edited

Loading

karlp Oct 20, 2023

karlp Oct 20, 2023

andrewleech Mar 28, 2024

EngineerWill Apr 1, 2024

karlp Oct 20, 2023

karlp Oct 20, 2023

karlp Oct 20, 2023

karlp Oct 20, 2023

karlp Oct 20, 2023

karlp Oct 20, 2023

mungewell commented Mar 7, 2024

mungewell commented Mar 28, 2024

EngineerWill commented Apr 1, 2024

andrewleech commented Apr 1, 2024 •

edited

Loading

EngineerWill commented Apr 1, 2024

andrewleech commented Apr 1, 2024

github-actions bot commented Dec 23, 2024

Add some definition files for waveshare board. #9085

Are you sure you want to change the base?

Add some definition files for waveshare board. #9085

Conversation

EngineerWill commented Aug 22, 2022

robert-hh commented Aug 22, 2022

EngineerWill commented Aug 22, 2022

Flipje1955 commented May 31, 2023

EngineerWill commented Jun 1, 2023

Flipje1955 commented Jun 1, 2023

EngineerWill commented Jun 1, 2023

TheChymera commented Jun 1, 2023 • edited Loading

Flipje1955 commented Jun 1, 2023

EngineerWill commented Jun 2, 2023 • edited Loading

codecov bot commented Oct 17, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mungewell commented Mar 7, 2024

mungewell commented Mar 28, 2024

EngineerWill commented Apr 1, 2024

andrewleech commented Apr 1, 2024 • edited Loading

EngineerWill commented Apr 1, 2024

andrewleech commented Apr 1, 2024

github-actions bot commented Dec 23, 2024

TheChymera commented Jun 1, 2023 •

edited

Loading

EngineerWill commented Jun 2, 2023 •

edited

Loading

codecov bot commented Oct 17, 2023 •

edited

Loading

andrewleech commented Apr 1, 2024 •

edited

Loading