Skip to content

rp2/boards/WAVESHARE_RP2040_PLUS: Add Waveshare RP2040-Plus board. #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rp2/boards/WAVESHARE_RP2040_PLUS: Add Waveshare RP2040-Plus board. #9321

wants to merge 1 commit into from

Conversation

knuxify
Copy link

@knuxify knuxify commented Sep 15, 2022

No description provided.

@jimmo
Copy link
Member

jimmo commented Sep 15, 2022

Thanks @knuxify

Could you please rename to remove the _4MB. We're going to start merging the different flash sizes into single boards with multiple variants. See #8505 where @mattytrentini is adding support for board variants to the rp2 port.

In the meantime though, I don't think this board comes in other sizes, so just renaming it should be all you need to do for this PR. Please also send a corresponding PR to https://github.com/micropython/micropython-media for the board image.

@knuxify
Copy link
Author

knuxify commented Sep 15, 2022

I added the _4MB suffix to match the board file definition in the pico-sdk, there's also a 16MB variant in that repo but it indeed seems that it never reached the market.

Without that, I get this error:

PICO target board is waveshare_rp2040_plus.
CMake Error at /home/knuxify/projects/micropython/lib/pico-sdk/src/boards/generic_board.cmake:22 (message):
  Unable to find definition of board 'waveshare_rp2040_plus' (specified by
  PICO_BOARD):

     Looked for waveshare_rp2040_plus.h in /home/knuxify/projects/micropython/lib/pico-sdk/src/boards/include/boards (additional paths specified by PICO_BOARD_HEADER_DIRS)
     Looked for waveshare_rp2040_plus.cmake in /home/knuxify/projects/micropython/lib/pico-sdk/src/boards (additional paths specified by PICO_BOARD_CMAKE_DIRS)
Call Stack (most recent call first):
  /home/knuxify/projects/micropython/lib/pico-sdk/src/board_setup.cmake:28 (include)
  /home/knuxify/projects/micropython/lib/pico-sdk/src/CMakeLists.txt:15 (include)

Where should I define the PICO_BOARD override?

@jimmo
Copy link
Member

jimmo commented Sep 15, 2022

Where should I define the PICO_BOARD override?

At the start of mpconfigboard.cmake

See e.g. https://github.com/micropython/micropython/blob/master/ports/rp2/boards/W5100S_EVB_PICO/mpconfigboard.cmake

Signed-off-by: Artur Weber <aweber@dithernet.org>
@knuxify knuxify changed the title rp2/boards/WAVESHARE_RP2040_PLUS_4MB: Add Waveshare RP2040-Plus board. rp2/boards/WAVESHARE_RP2040_PLUS: Add Waveshare RP2040-Plus board. Sep 15, 2022
@knuxify
Copy link
Author

knuxify commented Jan 1, 2023

I'll let #10314 supersede this one.

@knuxify knuxify closed this Jan 1, 2023
@RetiredWizard
Copy link

Sorry, I obviously didn't search open pull requests :/ I'll be sure for future PRs....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants