py/obj: Verify floating point type is correct for OBJ_REPR_C. #9649
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents double-precision floats being enabled on 32-bit architectures where they will not fit into the mp_obj_t encoding. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
Yes, there's a longer discussion here: #8547 (comment) We don't need double precision, but we do need |
Actually I'm sending a PR to update the board config, will set it to single. |
Using repr C is incompatible with double-precision floats on 32-bit arch. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
86fc52e to
83f3517
Compare
|
OK sure thing. I've updated the branch, but can drop the commit later in the rebase if necessary. |
|
It's fixed here too along with misc small fixes #9657 |
|
@dpgeorge Could you please merge this, because it includes a critical fix for Portenta board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents double-precision floats being enabled on 32-bit architectures where they will not fit into the mp_obj_t encoding.
Also reverts the Portenta board to the default representation as it uses double-precision floats.
@iabdalkader -- I'm not sure why the Portenta was set to OBJ_REPR_C, assuming to avoid heap-allocation of floats. If you want to keep that I guess we could switch the Portenta to use single-precision float instead?