This repository was archived by the owner on Sep 6, 2023. It is now read-only.
esp32/machine_pwm: Add support for all PWM timers and modes. #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP32 has 16 PWM channels with 8 separate timers, but current PWM implementation
forces user to share single timer between all channels. This commit
allows to use all 8 timers and does not break backward compatibility.
API additions:
- PWM initializer takes two new optional keyword arguments:
`pwm.init(..., timer=0, speed_mode=PWM.HIGH_SPEED_MODE)`
- PWM class defines two new constants:
`PWM.HIGH_SPEED_MODE` and `PWM.LOW_SPEED_MODE`
|
G'day! Thanks, having access to all PWM channels sounds like a good addition. I'll have a closer look as soon as possible. However, we've moved our development across to the main 'micropython/micropython' repo, so if possible could you please rebase onto master and submit a PR over there? -----Nick |
|
Hi Nick, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 has 16 PWM channels with 8 separate timers, but current PWM implementation
forces user to share single timer between all channels. This commit
allows to use all 8 timers and does not break backward compatibility.
API additions:
pwm.init(..., timer=0, speed_mode=PWM.HIGH_SPEED_MODE)PWM.HIGH_SPEED_MODEandPWM.LOW_SPEED_MODEExample:
There are 4 low speed timers and 4 high speed timers on ESP32.