lora: Fix SNR value in SX126x received packets. #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hlym123 thanks again for the very clear bug report! |
dpgeorge
approved these changes
Apr 24, 2025
Wasn't being treated as a signed value. Fixes issue micropython#999. Signed-off-by: Angus Gratton <angus@redyak.com.au>
58c3e31 to
f8c8875
Compare
|
@dpgeorge Oops, thanks for bumping the manifest version! |
No worries! It's a habit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't being treated as a signed value. Closes #999 .
Tested on NUCLEO-WL55 (same underlying driver as SX126x), by moving the transmitter far enough away for SNR to be <0dB.