Skip to content

pre_commit, ci: Bump the Ruff version to 0.11.6. #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ruff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: pip install --user ruff==0.1.2
# Version should be kept in sync with .pre-commit_config.yaml & also micropython
- run: pip install --user ruff==0.11.6
- run: ruff check --output-format=github .
- run: ruff format --diff .
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ repos:
verbose: true
stages: [commit-msg]
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.1.2
# Version should be kept in sync with .github/workflows/ruff.yml & also micropython
rev: v0.11.6
hooks:
- id: ruff
id: ruff-format
16 changes: 8 additions & 8 deletions micropython/aiorepl/aiorepl.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async def task(g=None, prompt="--> "):
continue
if curs:
# move cursor to end of the line
sys.stdout.write("\x1B[{}C".format(curs))
sys.stdout.write("\x1b[{}C".format(curs))
curs = 0
sys.stdout.write("\n")
if cmd:
Expand All @@ -153,10 +153,10 @@ async def task(g=None, prompt="--> "):
if curs:
cmd = "".join((cmd[: -curs - 1], cmd[-curs:]))
sys.stdout.write(
"\x08\x1B[K"
"\x08\x1b[K"
) # move cursor back, erase to end of line
sys.stdout.write(cmd[-curs:]) # redraw line
sys.stdout.write("\x1B[{}D".format(curs)) # reset cursor location
sys.stdout.write("\x1b[{}D".format(curs)) # reset cursor location
else:
cmd = cmd[:-1]
sys.stdout.write("\x08 \x08")
Expand Down Expand Up @@ -207,21 +207,21 @@ async def task(g=None, prompt="--> "):
elif key == "[D": # left
if curs < len(cmd) - 1:
curs += 1
sys.stdout.write("\x1B")
sys.stdout.write("\x1b")
sys.stdout.write(key)
elif key == "[C": # right
if curs:
curs -= 1
sys.stdout.write("\x1B")
sys.stdout.write("\x1b")
sys.stdout.write(key)
elif key == "[H": # home
pcurs = curs
curs = len(cmd)
sys.stdout.write("\x1B[{}D".format(curs - pcurs)) # move cursor left
sys.stdout.write("\x1b[{}D".format(curs - pcurs)) # move cursor left
elif key == "[F": # end
pcurs = curs
curs = 0
sys.stdout.write("\x1B[{}C".format(pcurs)) # move cursor right
sys.stdout.write("\x1b[{}C".format(pcurs)) # move cursor right
else:
# sys.stdout.write("\\x")
# sys.stdout.write(hex(c))
Expand All @@ -231,7 +231,7 @@ async def task(g=None, prompt="--> "):
# inserting into middle of line
cmd = "".join((cmd[:-curs], b, cmd[-curs:]))
sys.stdout.write(cmd[-curs - 1 :]) # redraw line to end
sys.stdout.write("\x1B[{}D".format(curs)) # reset cursor location
sys.stdout.write("\x1b[{}D".format(curs)) # reset cursor location
else:
sys.stdout.write(b)
cmd += b
Expand Down
2 changes: 1 addition & 1 deletion micropython/bluetooth/aioble/examples/l2cap_file_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ async def download(self, path, dest):

await self._command(_COMMAND_SEND, path.encode())

with open(dest, "wb") as f: # noqa: ASYNC101
with open(dest, "wb") as f: # noqa: ASYNC230
total = 0
buf = bytearray(self._channel.our_mtu)
mv = memoryview(buf)
Expand Down
2 changes: 1 addition & 1 deletion micropython/bluetooth/aioble/examples/l2cap_file_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async def l2cap_task(connection):

if send_file:
print("Sending:", send_file)
with open(send_file, "rb") as f: # noqa: ASYNC101
with open(send_file, "rb") as f: # noqa: ASYNC230
buf = bytearray(channel.peer_mtu)
mv = memoryview(buf)
while n := f.readinto(buf):
Expand Down
12 changes: 4 additions & 8 deletions micropython/drivers/codec/wm8960/wm8960.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,7 @@ def __init__(
sysclk = 11289600
else:
sysclk = 12288000
if sysclk < sample_rate * 256:
sysclk = sample_rate * 256
sysclk = max(sysclk, sample_rate * 256)
if mclk_freq is None:
mclk_freq = sysclk
else: # sysclk_source == SYSCLK_MCLK
Expand Down Expand Up @@ -691,10 +690,8 @@ def alc_mode(self, channel, mode=ALC_MODE):
def alc_gain(self, target=-12, max_gain=30, min_gain=-17.25, noise_gate=-78):
def limit(value, minval, maxval):
value = int(value)
if value < minval:
value = minval
if value > maxval:
value = maxval
value = max(value, minval)
value = min(value, maxval)
return value

target = limit((16 + (target * 2) // 3), 0, 15)
Expand All @@ -718,8 +715,7 @@ def logb(value, limit):
while value > 1:
value >>= 1
lb += 1
if lb > limit:
lb = limit
lb = min(lb, limit)
return lb

attack = logb(attack / 6, 7)
Expand Down
6 changes: 2 additions & 4 deletions micropython/drivers/display/lcd160cr/lcd160cr.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,8 @@ def clip_line(c, w, h):
c[3] = h - 1
else:
if c[0] == c[2]:
if c[1] < 0:
c[1] = 0
if c[3] < 0:
c[3] = 0
c[1] = max(c[1], 0)
c[3] = max(c[3], 0)
else:
if c[3] < c[1]:
c[0], c[2] = c[2], c[0]
Expand Down
1 change: 1 addition & 0 deletions micropython/drivers/imu/lsm9ds1/lsm9ds1.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
print("")
time.sleep_ms(100)
"""

import array
from micropython import const

Expand Down
3 changes: 1 addition & 2 deletions micropython/drivers/radio/nrf24l01/nrf24l01.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"""NRF24L01 driver for MicroPython
"""
"""NRF24L01 driver for MicroPython"""

from micropython import const
import utime
Expand Down
2 changes: 1 addition & 1 deletion micropython/drivers/sensor/hts221/hts221.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def __init__(self, i2c, data_rate=1, address=0x5F):

# Set configuration register
# Humidity and temperature average configuration
self.bus.writeto_mem(self.slv_addr, 0x10, b"\x1B")
self.bus.writeto_mem(self.slv_addr, 0x10, b"\x1b")

# Set control register
# PD | BDU | ODR
Expand Down
1 change: 1 addition & 0 deletions micropython/drivers/sensor/lps22h/lps22h.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
print("Pressure: %.2f hPa Temperature: %.2f C"%(lps.pressure(), lps.temperature()))
time.sleep_ms(10)
"""

import machine
from micropython import const

Expand Down
16 changes: 8 additions & 8 deletions micropython/espflash/espflash.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,22 @@ def _poll_reg(self, addr, flag, retry=10, delay=0.050):
raise Exception(f"Register poll timeout. Addr: 0x{addr:02X} Flag: 0x{flag:02X}.")

def _write_slip(self, pkt):
pkt = pkt.replace(b"\xDB", b"\xdb\xdd").replace(b"\xc0", b"\xdb\xdc")
self.uart.write(b"\xC0" + pkt + b"\xC0")
pkt = pkt.replace(b"\xdb", b"\xdb\xdd").replace(b"\xc0", b"\xdb\xdc")
self.uart.write(b"\xc0" + pkt + b"\xc0")
self._log(pkt)

def _read_slip(self):
pkt = None
# Find the packet start.
if self.uart.read(1) == b"\xC0":
if self.uart.read(1) == b"\xc0":
pkt = bytearray()
while True:
b = self.uart.read(1)
if b is None or b == b"\xC0":
if b is None or b == b"\xc0":
break
pkt += b
pkt = pkt.replace(b"\xDB\xDD", b"\xDB").replace(b"\xDB\xDC", b"\xC0")
self._log(b"\xC0" + pkt + b"\xC0", False)
pkt = pkt.replace(b"\xdb\xdd", b"\xdb").replace(b"\xdb\xdc", b"\xc0")
self._log(b"\xc0" + pkt + b"\xc0", False)
return pkt

def _strerror(self, err):
Expand Down Expand Up @@ -230,7 +230,7 @@ def flash_read_size(self):
raise Exception(f"Unexpected flash size bits: 0x{flash_bits:02X}.")

flash_size = 2**flash_bits
print(f"Flash size {flash_size/1024/1024} MBytes")
print(f"Flash size {flash_size / 1024 / 1024} MBytes")
return flash_size

def flash_attach(self):
Expand Down Expand Up @@ -265,7 +265,7 @@ def flash_write_file(self, path, blksize=0x1000):
self.md5sum.update(buf)
# The last data block should be padded to the block size with 0xFF bytes.
if len(buf) < blksize:
buf += b"\xFF" * (blksize - len(buf))
buf += b"\xff" * (blksize - len(buf))
checksum = self._checksum(buf)
if seq % erase_blocks == 0:
# print(f"Erasing {seq} -> {seq+erase_blocks}...")
Expand Down
2 changes: 1 addition & 1 deletion micropython/lora/examples/reliable_delivery/sender.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def send(self, sensor_data, adjust_output_power=True):
delta = time.ticks_diff(maybe_ack.ticks_ms, sent_at)
print(
f"ACKed with RSSI {rssi}, {delta}ms after sent "
+ f"(skew {delta-ACK_DELAY_MS-ack_packet_ms}ms)"
+ f"(skew {delta - ACK_DELAY_MS - ack_packet_ms}ms)"
)

if adjust_output_power:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ async def send(self, sensor_data, adjust_output_power=True):
delta = time.ticks_diff(maybe_ack.ticks_ms, sent_at)
print(
f"ACKed with RSSI {rssi}, {delta}ms after sent "
+ f"(skew {delta-ACK_DELAY_MS-ack_packet_ms}ms)"
+ f"(skew {delta - ACK_DELAY_MS - ack_packet_ms}ms)"
)

if adjust_output_power:
Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/actuator.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *


Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time

Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time

Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/basic2.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time

Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/basic_cbor.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time
import cbor2
Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/custom_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *

import time
Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/gateway.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time

Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/gateway_actuators.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *


Expand Down
1 change: 0 additions & 1 deletion micropython/senml/examples/supported_data_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml import *
import time

Expand Down
1 change: 0 additions & 1 deletion micropython/senml/senml/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from .senml_base import SenmlBase
from .senml_pack import SenmlPack
from .senml_record import SenmlRecord
Expand Down
1 change: 0 additions & 1 deletion micropython/senml/senml/senml_pack.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from senml.senml_record import SenmlRecord
from senml.senml_base import SenmlBase
import json
Expand Down
1 change: 0 additions & 1 deletion micropython/senml/senml/senml_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


import binascii
from senml.senml_base import SenmlBase

Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,15 @@ ignore = [
"ISC003", # micropython does not support implicit concatenation of f-strings
"PIE810", # micropython does not support passing tuples to .startswith or .endswith
"PLC1901",
"PLR1701",
"PLR1704", # sometimes desirable to redefine an argument to save code size
"PLR1714",
"PLR5501",
"PLW0602",
"PLW0603",
"PLW2901",
"RUF012",
"RUF100",
"SIM101",
"W191", # tab-indent, redundant when using formatter
]
line-length = 99
Expand Down
1 change: 0 additions & 1 deletion python-ecosys/cbor2/cbor2/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


from ._decoder import CBORDecoder
from ._decoder import load
from ._decoder import loads
Expand Down
1 change: 0 additions & 1 deletion python-ecosys/cbor2/cbor2/_decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


import io
import struct

Expand Down
1 change: 0 additions & 1 deletion python-ecosys/cbor2/cbor2/_encoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


import io
import struct

Expand Down
1 change: 0 additions & 1 deletion python-ecosys/cbor2/examples/cbor_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
THE SOFTWARE.
"""


import cbor2

input = [
Expand Down
Loading