logging: support for file based logging #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz2101
reviewed
Dec 29, 2019
| try: | ||
| os.remove(log_file) | ||
| except OSError: | ||
| pass |
There was a problem hiding this comment.
Is it good approach to silently pass error?
| logging.info("%d %s" % (i, sample)) | ||
| stdout_delta = time.time() - start_time | ||
| print("File logging time %f for %i iterations" % (file_delta, iterations)) | ||
| print("Stdout logging time %f for %i iterations" % (stdout_delta, iterations)) |
There was a problem hiding this comment.
Why do you want to put this function in example ?
| print(msg, file=_stream) | ||
| else: | ||
| print(msg % args, file=_stream) | ||
|
|
There was a problem hiding this comment.
Can we write to stream and file in same time?
|
File based logging was added in #507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic file logging support
Added unittest for basicConfig when using files
Added stress test for logging to file and std stream