urequests: request function can take custom response class #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `response_class` keyword arg to `urequests.request`, which defaults to `urequests.Response` and is used to instantiate the object handling the HTTP response. * Call `set_header` method (if defined) on instance of given response class for every received header line, which takes an unparsed header line as a byte string.
341530c to
a0abe1e
Compare
|
Simplified the patch by checking for the |
|
Thanks to the dynamic nature of (micro)python the class replacement can already be done with normal monkey-patching, eg. import urequests
class Response(urequests.Response)
def set_header(self, line):
pass # do stuff
urequests.Response = ResponseThe other change here to extend headers handling I think would be covered by 5854ae1 recently merged as part of #500. Feel free to re-open / update the PR if I've missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response_classkeyword arg tourequests.request,which defaults to
urequests.Responseand is used toinstantiate the object handling the HTTP response.
set_headermethod on instance of given responseclass for every received header line, which takes an
unparsed header line as a byte string.
set_headermethod tourequests.Response.This could be used to store the response headers in a custom response class as demonstrated in this comment for #217. It is the responsibility of the custom response class to properly parse and assemble headers (e.g. ones with continuation lines).