umqtt.simple: allow no password in connect packet #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfa92f6 to
e18ef5a
Compare
e18ef5a to
1525394
Compare
|
Closing this since I'm cleaning my unmerged PRs and this hasn't been acted upon in years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
umqtt.simple.MQTTClientincorrectly assumes that if the user is set, the password is notNone. If password is set toNone, the password flag in the connect headers should not be set and no password should be sent to the server.Further discussion here: https://forum.micropython.org/viewtopic.php?p=29636#p29598