Skip to content

Conversation

diefesson
Copy link
Contributor

@diefesson diefesson commented Sep 30, 2020

Added support for chunked requests, allowing urequests to send data of
unknown size (eg: generated or collected data that would be too big to
be stored in RAM), and HTTP redirection ("Location" header) support
for temporary and permanent redirection.

@andrewleech
Copy link
Contributor

andrewleech commented Jul 3, 2022

Hi, a version of this PR has been merged in #500, commits be327a7, b17e9aa & b29cffb.

@diefesson I hope you don't mind, I maintained your authorship on the commits even though I changed them slightly based on review comments and split the redirects & chunk handling into two separate commits for clarity of change.

  • replace <str>.decode() with str(<str>, "utf-8") as not all ports have the decode functione enabled.
  • squash the chunked_data function into an inline check - while the function is arguably clearer to read it results in slightly larger bytecode, so the inline version saves flash/ram.

@andrewleech andrewleech closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants