Skip to content

python-stdlib/threading: Add Lock, Condition and Event to threading. #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrewleech
Copy link
Contributor

Requires #440

@dpgeorge
Copy link
Member

PR #440 was closed without merging. The code is now in upstream, but the clear() method is not implemented.

Can you change this code here so it doesn't need deque.clear()?

Also, what's the licensing of the code here, is it copied from CPython?

@andrewleech
Copy link
Contributor Author

andrewleech commented May 31, 2024

Thanks yes I'll update that.

These classes were copied from cpython yes, with very minimal updates for compatibility if I recall correctly.

The licencing declaration is a good point, thanks for bringing it up. I'm not sure if it's possible/appropriate to keep these in the same file as the existing (MIT presumably) Thread class? I could comment each of these classes with licence / link to original cpython implementation, or perhaps they need to move to a separate file with suitable comment at the top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants