python-stdlib/hmac: Update to work with built-in hash functions. #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #369 |
This was referenced Aug 8, 2022
9c8eb60 to
6604385
Compare
This was referenced Aug 8, 2022
This library was non-functional unless used with the micropython-lib pure-Python implementation of hashlib, even if the device provides sha1 and sha256. This updates hmac to be significantly more RAM efficient (removes the 512-byte table), and functional with the built-in hash functions. The only unsupported function is "copy", but this is non-critical, and now fails with a NotSupportedError. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
6604385 to
1bb5812
Compare
|
Thanks! This was on my list for a long time.... Merged in f95260d with a minor fix, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library was non-functional unless used with the micropython-lib
pure-Python implementation of hashlib, even if the device provides
sha1 and sha256.
This updates hmac to be significantly more RAM efficient (removes the
512-byte table), and functional with the built-in hash functions.
The only unsupported function is "copy", but this is non-critical, and now
fails with a NotSupportedError.