There's also settime() which calls time(), and probably should also allow passing in the timeout.

But then maybe a better way to do it is have a global variable to set the timeout. This will match how you select the NTP host.

Eg:

host = "pool.ntp.org"
timeout = 1

...

    s.settimeout(timeout)

I think the host should be private and the default ex: _HOST and a default timeout _TIMEOUT=const(1.0) , and both functions accept kwordargs settime(timeout=_DEFAULT_TIMEOUT, host=_DEFAULT_HOST)

@dpgeorge How about now ?

But this changes the existing public API, where you change ntptime.host to configure your desired server. We had a lot of PRs to change this behaviour already and that's why there's a comment there describing how to use it.

The idea behind having a global variable is that you can change it once -- configure it -- then you don't need to pass it in to time() every time you call it. IMO setting it once to a set value is a more common use case that passing in potentially different hosts at different locations where this is called.

(Note that it's not such bad practice having a global here, because the ntptime itself is very small and self contained, you can think of ntptime as being a singleton class, and ntptime.host as being a property that you get/set.)

Okay, I see your point, it's not important as long as we can override it somehow. Added a timeout globally just like host

Thanks for updating. Merged in 900dd1c (and I change the default from "1.0" to "1" so it doesn't use a float if it doesn't need to).