Skip to content

top: Update top-level docs. #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

top: Update top-level docs. #576

merged 1 commit into from
Dec 16, 2022

Conversation

jimmo
Copy link
Member

@jimmo jimmo commented Nov 15, 2022

  • Add instructions for how to use micropython-lib.
  • Add a terminology guide and use consistent terminology (package/module/library).
  • Improve code conventions and contributor guidelines.
  • Misc readme updates.

This work was funded through GitHub Sponsors.

@jimmo jimmo force-pushed the top-level-docs branch 4 times, most recently from 0b1aaaf to ac7acf7 Compare November 15, 2022 12:13
@jimmo
Copy link
Member Author

jimmo commented Nov 15, 2022

Copy link
Contributor

@mattytrentini mattytrentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvements Jim! Much clearer.

README.md Outdated
Comment on lines 20 to 23
in other Python environments. This includes drivers for hardware
(e.g. sensors, peripherals, or displays), or libraries to work with
embedded functionality (e.g. bluetooth), or MicroPython-specific
packages that do not have equivalents in CPython.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in other Python environments. This includes drivers for hardware
(e.g. sensors, peripherals, or displays), or libraries to work with
embedded functionality (e.g. bluetooth), or MicroPython-specific
packages that do not have equivalents in CPython.
in other Python environments. This includes drivers for hardware
(e.g. sensors, peripherals or displays), libraries to work with
embedded functionality (e.g. bluetooth) or MicroPython-specific
packages that do not have equivalents in CPython.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the or.

README.md Outdated

Other libraries are packages, in which case you'll need to copy the directory instead. For example, to add `collections.defaultdict`, copy `collections/collections/__init__.py` and `collections.defaultdict/collections/defaultdict.py` to a directory named `lib/collections` on your device.
### On a network-enabled device:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that, generally, colons in titles were considering unnecessary. Style choice though!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

CONTRIBUTING.md Outdated
required functionality can be installed. The way to do this is to have a
base package, e.g. `mypackage` containing `mypackage/__init__.py`, and then
an "extension" package, e.g. `mypackage-ext` containing additional files
e.g. `mypackage/ext.py`. See `collections-defaultdict` as an example.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a link if we want the user to see an example:

Suggested change
e.g. `mypackage/ext.py`. See `collections-defaultdict` as an example.
e.g. `mypackage/ext.py`. See [`collections-defaultdict`](https://github.com/micropython/micropython-lib/tree/master/python-stdlib/collections-defaultdict) as an example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think code can also be a link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did render correctly when I tried it in the Discussion preview window...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! That's neat. Updated.

@jimmo
Copy link
Member Author

jimmo commented Nov 15, 2022

Thanks @mattytrentini -- updated!

@andrewleech
Copy link
Contributor

Looks great to me, fantastic work. I now feel the examples to manually copy code onto devices is almost too much, but serves to highlight how easy mip is by comparison.

@andrewleech
Copy link
Contributor

I also had a previous PR to add since developer guidance to the readme, there might be a couple of extra notes there worth adding (though you've certainly covered most of it now) https://github.com/micropython/micropython-lib/pull/495/files

* Add instructions for how to use micropython-lib.
* Add a terminology guide and use consistent terminology
  (package/module/library).
* Improve code conventions and contributor guidelines.
* Misc readme updates.

This work was funded through GitHub Sponsors.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
@jimmo
Copy link
Member Author

jimmo commented Dec 16, 2022

Thanks, updated!

@dpgeorge dpgeorge merged commit a9e52d0 into master Dec 16, 2022
@dpgeorge dpgeorge deleted the top-level-docs branch December 16, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants