Skip to content

Fix misleading connection string message #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2024

Conversation

jeanbisutti
Copy link
Member

The following error messages were displayed for cases not related to a misconfiguration of a connection string from a file:

Error loading connection string from a file

Please use this format instead:
{ "connectionString": "${file:connection-string-file.txt}" }

For example totoInstrumentationKey for a connection string creates these error messages.

It can be misleading for the users.

Related to #3707

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jeanbisutti and others added 3 commits May 21, 2024 11:25
…ights/agent/internal/configuration/ConfigurationBuilder.java

Co-authored-by: Helen <56097766+heyams@users.noreply.github.com>
…ights/agent/internal/configuration/ConfigurationBuilder.java

Co-authored-by: Helen <56097766+heyams@users.noreply.github.com>
@jeanbisutti jeanbisutti enabled auto-merge (squash) May 21, 2024 09:38
@jeanbisutti jeanbisutti merged commit f30c846 into main May 21, 2024
87 checks passed
@jeanbisutti jeanbisutti deleted the jean/fix-misleading-connection-string-message branch May 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants