Change MethodBindResult to a readonly ref struct #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AnsisMalins, This is a good change; thanks for contributing it. We're a bit concerned about the errors you mentioned, so we'll build your branch and take a look before merging. Thanks again! |
ClearScriptLib
added a commit
that referenced
this pull request
Mar 7, 2025
…; overhauled the codebase in favor of static lambdas; replaced most scope objects with ref structures; minimized boxing and structure copying on performance-critical code paths; eliminated the use of argument vectors for host calls with typical argument counts; [V8] added span support to array buffers and related types (GitHub Issue #632); [V8] enhanced task-promise interop with support for pre-settled promises and pre-completed tasks (GitHub Issue #641); [V8] added V8ScriptEngineFlags.EnableArrayConversion (GitHub Issue #634); [V8] fixed fast data transfer bounds checking for zero-length arrays and buffers (GitHub Issue #581); [V8] added import.meta.setResult to enable reliable module evaluation results; [V8] fixed MaxHeapSize and MaxRuntimeHeapSize behavior (GitHub Issue #571); incorporated Ansis Māliņš' conversion of MethodBindResult to a ref structure (GitHub PR #616); added promise state indicators to JavaScriptObjectFlags; fixed XMLDOM enumeration issue discussed in GitHub Issue #594; added sparse argument support to the reflection binder (GitHub Discussion #624); added ScriptEngine.NullImportValue (GitHub Issue #629); switched to XML for assembly table storage to eliminate security issues related to BinaryFormatter; updated API documentation. Tested with V8 13.3.415.23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
MethodBindResultareadonly ref structto reduce of GC allocations when calling into JavaScript.All unit tests passed, but there were 12 errors of the form