Skip to content

Fix jsdoc missing space from bad indent #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2016
Merged

Fix jsdoc missing space from bad indent #12156

merged 2 commits into from
Nov 14, 2016

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Nov 10, 2016 •
edited
Loading

Fixes #10987
Fixes #11341

Thanks @andreasrueedlinger for the repro and fix.

@sandersn
Retain space after first word in multiline jsdoc
8bd0a47 
For words that were shorter than the jsdoc indent level, the space was
omitted previously.
@sandersn
Merge branch 'master' into fix-jsdoc-missing-space-from-bad-indent
973d83c
@sandersn sandersn mentioned this pull request Nov 10, 2016
Closed
@sandersn
Copy link
Member Author

@Andy-MS pointed out that this PR also fixes #11341

@sandersn sandersn merged commit 0cda239 into master Nov 14, 2016
@sandersn sandersn deleted the fix-jsdoc-missing-space-from-bad-indent branch November 14, 2016 16:21
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing space in documentation comment quick info Indent is not reset after first line break in jsdoc parser
3 participants
@sandersn @mhegazy @msftclas