Skip to content

Fix variable type inference circularity #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2017
Merged

Fix variable type inference circularity #14446

merged 4 commits into from
Mar 4, 2017

Conversation

ahejlsberg
Copy link
Member

Fixes #14428.

@ahejlsberg ahejlsberg merged commit 19e88ac into master Mar 4, 2017
@ahejlsberg ahejlsberg deleted the circularVarTypeInference branch March 4, 2017 00:01
alfaproject
alfaproject reviewed Mar 4, 2017
View reviewed changes
tests/baselines/reference/implicitAnyFromCircularInference.errors.txt
@@ -71,8 +70,6 @@ tests/cases/compiler/implicitAnyFromCircularInference.ts(46,9): error TS7023: 'x
class C {
// Error expected
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess no error expected anymore?

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahejlsberg @alfaproject @mhegazy @msftclas