Skip to content

In getWidenedTypeFromJSSpecialPropertyDeclarations, parent of PropertyAccessExpression must be a BinaryExpression #22727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Apr 10, 2018
Merged

In getWidenedTypeFromJSSpecialPropertyDeclarations, parent of PropertyAccessExpression must be a BinaryExpression #22727

1 commit merged into from
Apr 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2018

Noticed while reviewing #22721

In getWidenedTypeFromJSSpecialPropertyDeclarations, parent of Propert…
1752bf8 
…yAccessExpression must be a BinaryExpression
@ghost ghost requested a review from sandersn March 20, 2018 18:54
@ghost
Copy link
Author

ghost commented Apr 10, 2018

@sandersn Could you review?

sandersn
sandersn approved these changes Apr 10, 2018
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this one slipped through the cracks.

@ghost ghost merged commit dcc4b88 into master Apr 10, 2018
@ghost ghost deleted the castIsBinaryExpression branch April 10, 2018 21:46
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sandersn