Adjusted newlines in non-pretty output for consistency #23470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Apr 17, 2018
|
@sheetalkamat any comments? |
src/compiler/watch.ts
Outdated
| system.write(output); | ||
| } : | ||
| (diagnostic, newLine, options) => { | ||
| clearScreenIfNotWatchingForFileChanges(system, diagnostic, options); | ||
| let output = new Date().toLocaleTimeString() + " - "; | ||
| output += `${flattenDiagnosticMessageText(diagnostic.messageText, system.newLine)}${newLine + newLine + newLine}`; | ||
| let output = `${getPlainDiagnosticPrecedingNewLines(diagnostic, newLine)}${new Date().toLocaleTimeString()} - `; |
There was a problem hiding this comment.
This may depend on whether screen was cleared or not as well right ?
There was a problem hiding this comment.
@sheetalkamat thanks, it does!
src/compiler/watch.ts
Outdated
| @@ -75,7 +75,7 @@ namespace ts { | |||
| } : | |||
| (diagnostic, newLine, options) => { | |||
| clearScreenIfNotWatchingForFileChanges(system, diagnostic, options); | |||
There was a problem hiding this comment.
may be let clearScreenIfNotWatchingForFiles send you the return value if the screen is cleared since it is not cleared in options.extendedDiagostics || options.diagnostics too.
sheetalkamat
approved these changes
Apr 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23469