Skip to content

es2018 regexp dotAll #24238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

es2018 regexp dotAll #24238

merged 1 commit into from
May 18, 2018

Conversation

bluelovers
Copy link
Contributor

@mhegazy mhegazy merged commit 2e183f5 into microsoft:master May 18, 2018
@mhegazy
Copy link
Contributor

mhegazy commented May 18, 2018

thanks!

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 19, 2018 •
edited
Loading

This file was edited in lib which we've explicitly asked people not to do in the README 👎

mhegazy added a commit that referenced this pull request May 19, 2018
@mhegazy
Port changes in #24238 to source file
c19408b
@mhegazy mhegazy mentioned this pull request May 19, 2018
Merged
@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2018

good catch. should have caught this earlier.. PR up in #24271

mhegazy added a commit that referenced this pull request May 19, 2018
@mhegazy
Merge pull request #24271 from Microsoft/portRegExpDotAllFix
153c180 
Port changes in #24238 to source file
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajafff ajafff ajafff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluelovers @mhegazy @DanielRosenwasser @ajafff