Support project reference builds in gulp builds #25066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Jun 20, 2018
weswigham
reviewed
Jun 20, 2018
src/compiler/tsbuild.ts
Outdated
| }; | ||
| } | ||
|
|
||
| if (project === undefined) { |
There was a problem hiding this comment.
Probably due to merging master.
mhegazy
approved these changes
Jun 20, 2018
…p.watch support later
|
I have some cleanup pending that I'll publish before we merge. |
|
There are also a number of unexpected differences in the LKG I want to look at before we take this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores support for building TypeScript using gulp now that gulp-typescript has minimal support for project references.
This was accomplished using the following changes:
gulp.taskrelated logic has been moved out to individual gulp "plugin" scripts in scripts/build.NOTE: I've needed to temporarily disable support for gulp.watch as I still need to clean up/expire changed "projects" from the cache in scripts/build/project.js, but that could happen in a later PR.