Don't report quickInfo inside a comment in a PropertyAccessExpression #25813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Jul 20, 2018
| @@ -1489,6 +1472,23 @@ namespace ts { | |||
| }; | |||
| } | |||
|
|
|||
| function shouldGetType(sourceFile: SourceFile, node: Node, position: number): boolean { | |||
There was a problem hiding this comment.
this is purely stylistic. but i think it read better before. in general refactoring inner pieces of logic that are rather specific to a certain code path makes it harder to understand the flow.
There was a problem hiding this comment.
Previously we used switch-case fallthrough to determine whether to reach the last case. That was possible with only two cases, but it's not possible any more when we need two cases to both goto the same third case.
mhegazy
approved these changes
Jul 20, 2018
sheetalkamat
approved these changes
Jul 20, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19984