Changes to determine when to qualify the symbol in given enclosing declaration #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enclosing declaration Note that this doesnt handle aliases yet.
…ol whose name we are trying to get in the symbol table
…on needs to be emitted This would help in unifying logic of when to check if the type is visible
| else if (node.kind === SyntaxKind.SourceFile) { | ||
| return (node.flags & NodeFlags.ExternalModule) ? node : null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Assert that you won't get here
sheetalkamat
added a commit
that referenced
this pull request
Jul 16, 2014
Changes to determine when to qualify the symbol in given enclosing declaration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has changes for determining when to qualify symbol name and also moved the logic of isDeclarationVisible
Still todos are:
error reporting to use the enclosingDeclaration and meaning correctly to report the error message
isDeclarationVisible is setup in checker so it could be used to verify and report errors on visibility of types