🤖 User test baselines have changed #32837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e741222 to
08ea9d0
Compare
sandersn
approved these changes
Aug 13, 2019
| @@ -51,8 +51,6 @@ node_modules/async/autoInject.js(160,28): error TS2695: Left side of comma opera | |||
| node_modules/async/autoInject.js(164,14): error TS2695: Left side of comma operator is unused and has no side effects. | |||
| node_modules/async/autoInject.js(168,6): error TS2695: Left side of comma operator is unused and has no side effects. | |||
| node_modules/async/cargo.js(62,12): error TS2304: Cannot find name 'AsyncFunction'. | |||
| node_modules/async/cargo.js(67,14): error TS2749: 'module' refers to a value, but is being used as a type here. | |||
| node_modules/async/cargo.js(67,20): error TS1005: '}' expected. | |||
There was a problem hiding this comment.
loos like Orta's module:pathname skipping code went in yesterday
| @@ -1,15 +1,15 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/@typescript-eslint/typescript-estree/dist/parser.d.ts(1,8): error TS1259: Module '"/prettier/prettier/node_modules/typescript/lib/typescript"' can only be default-imported using the 'esModuleInterop' flag | |||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | |||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number'. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh