Skip to content

Disable signature help on unresolved bare identifiers; add more declaration info on other unresolved calls #39352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2020
Merged

Disable signature help on unresolved bare identifiers; add more declaration info on other unresolved calls #39352

merged 2 commits into from
Jun 30, 2020

Conversation

andrewbranch
Copy link
Member

Fixes #33565

Before After
image image
image image

@andrewbranch andrewbranch requested review from mjbvz and sandersn June 30, 2020 20:58
mjbvz
mjbvz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look!

@andrewbranch andrewbranch merged commit e2c5a90 into microsoft:master Jun 30, 2020
@andrewbranch andrewbranch deleted the bug/33565 branch March 10, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@mjbvz mjbvz mjbvz approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@andrewbranch andrewbranch

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected parameter hint showing up for log in js file
4 participants
@andrewbranch @RyanCavanaugh @mjbvz @typescript-bot