Remove some unnecessary code discovered by rollup #51204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, this code isn't dead in the sense that it doesn't run, but rather that the code has no effect, right? |
RyanCavanaugh
approved these changes
Oct 17, 2022
|
Yes, dead is the wrong term; I should have called it "unnecessary" because it does execute, but with no side effects and no result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the module branch, I enabled the "smallest" preset of Rollup to see what it'd do; it deleted a block of code, which appears to do nothing after the code that used
reportErrorwas removed in #8485. Rollup's static analysis appears to have understood that. Neat.