Exempt one type declaration from the redeclared export check - Fix #6043 #6044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ECMA262: 15.2.1.1 It is a Syntax Error if the ExportedNames of ModuleItemList contains any duplicate entries. (TS Exceptions: namespaces, function overloads, enums, and interfaces) | ||
| if (!(flags & (SymbolFlags.Namespace | SymbolFlags.Interface | SymbolFlags.Enum)) && declarations.length > 1) { | ||
| if (!(flags & (SymbolFlags.Namespace | SymbolFlags.Interface | SymbolFlags.Enum)) && (flags & SymbolFlags.TypeAlias ? declarationLength-- : true) && declarationLength > 1) { |
There was a problem hiding this comment.
Can you rewrite without -- so I can understand more easily?
There was a problem hiding this comment.
I think && (flags & SymbolFlags.TypeAlias ? declarations.length - 2 : declarations.length - 1) is an improvement since 0 is falsy.
There was a problem hiding this comment.
Actually && (flags & SymbolFlags.TypeAlias ? declarations.length - 1 : declarations.length) > 1 is even better.
|
:1+: |
|
Close enough to 👍! |
weswigham
added a commit
that referenced
this pull request
Dec 12, 2015
Exempt one type declaration from the redeclared export check - Fix #6043
|
It's the Common Lisp variant. You have to (apply :1+ ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.