This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Toolbar): add popup prop #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
==========================================
- Coverage 73.45% 73.44% -0.02%
==========================================
Files 822 822
Lines 6183 6190 +7
Branches 1793 1795 +2
==========================================
+ Hits 4542 4546 +4
- Misses 1636 1639 +3
Partials 5 5
Continue to review full report at Codecov.
|
sophieH29
reviewed
Jun 10, 2019
bmdalex
approved these changes
Jun 11, 2019
docs/src/examples/components/Toolbar/Types/ToolbarExampleEditor.shorthand.tsx
Show resolved
Hide resolved
mnajdova
reviewed
Jun 12, 2019
mnajdova
reviewed
Jun 12, 2019
mnajdova
reviewed
Jun 12, 2019
mnajdova
reviewed
Jun 13, 2019
mnajdova
approved these changes
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1410.
A Toolbar item can now have a popup:
API
popupprop was added to theToolbarItem. It is a shorthand forPopupcomponent, accepting all config valid for Popup with the following exceptions:accessibilitydefaults topopupFocusTrapBehavior(but can be overriden)childrenprop cannot be used, it is always reset by theToolbarItemtriggerprop cannot be used, it is force-set to theToolbarItem's buttonToolbaris a controlled component, it does not internally handle items' state. It is consumer's responsibility to handleMenuItem:activeprop based on thePopupstate.