Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat: Updating buttons to be in line with new styles #216

Merged
merged 8 commits into from
Sep 17, 2018
Merged

feat: Updating buttons to be in line with new styles #216

merged 8 commits into from
Sep 17, 2018

Conversation

notandrew
Copy link
Contributor

Updating the colors and borders to match current Teams redlines

@codecov
Copy link

codecov bot commented Sep 11, 2018 •
edited
Loading

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          61       61           
  Lines        1028     1028           
  Branches      155      155           
=======================================
  Hits          941      941           
  Misses         83       83           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4314b...d90585d. Read the comment docs.

@notandrew notandrew changed the title Updating buttons to be in line with new styles feat: Updating buttons to be in line with new styles Sep 11, 2018
@jurokapsiar
Copy link
Contributor

Text and starndard buttons are not readable when focused by keyboard:

image
image

Also, border for circular emphasis does not look correct:
image

Will these be part of separate PR or should they be fixed here?

@notandrew
Copy link
Contributor Author

Text and starndard buttons are not readable when focused by keyboard:

image
image

Also, border for circular emphasis does not look correct:
image

Will these be part of separate PR or should they be fixed here?

@jurokapsiar -- I wasn't looking at those buttons for some reason. I fixed the outlines for non-primary & secondary buttons. In a future checkin, I'll update those to the correct styles.

@notandrew notandrew merged commit 12c512f into master Sep 17, 2018
@notandrew notandrew deleted the feature/buttons-theme-teams-2 branch September 17, 2018 17:35
@notandrew notandrew mentioned this pull request Sep 19, 2018
Closed
@jurokapsiar jurokapsiar mentioned this pull request Nov 20, 2018
Closed
@bmdalex bmdalex mentioned this pull request Dec 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kuzhelov kuzhelov kuzhelov approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@levithomason levithomason

Labels
ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notandrew @jurokapsiar @kuzhelov @levithomason