Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Update themeing for hover/focus states to have a cyan background #680204 #2374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update themeing for hover/focus states to have a cyan background #680204 #2374

wants to merge 1 commit into from

Conversation

TanelVari
Copy link
Contributor

No description provided.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.5 0.37 1.35:1 2000 997
🦄 Button.Fluent 0.1 0.17 0.59:1 1000 101
🔧 Checkbox.Fluent 0.75 0.27 2.78:1 1000 746
🔧 Dialog.Fluent 0.34 0.17 2:1 5000 1676
🔧 Dropdown.Fluent 3.28 0.39 8.41:1 1000 3283
🔧 Icon.Fluent 0.14 0.03 4.67:1 5000 692
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 229
🔧 Slider.Fluent 1.45 0.32 4.53:1 1000 1445
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 265
🦄 Tooltip.Fluent 0.1 16.85 0.01:1 5000 496

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PopupMinimalPerf.default 397 316 1.26:1
ChatDuplicateMessagesPerf.default 480 384 1.25:1
SliderMinimalPerf.default 1712 1472 1.16:1
Icon.Fluent 692 597 1.16:1
ImageMinimalPerf.default 268 238 1.13:1
BoxMinimalPerf.default 248 225 1.1:1
Tooltip.Fluent 496 449 1.1:1
InputMinimalPerf.default 1031 955 1.08:1
TextMinimalPerf.default 271 250 1.08:1
Avatar.Fluent 997 924 1.08:1
HeaderSlotsPerf.default 1502 1402 1.07:1
Dialog.Fluent 1676 1569 1.07:1
AccordionMinimalPerf.default 196 185 1.06:1
HeaderMinimalPerf.default 463 437 1.06:1
RefMinimalPerf.default 155 146 1.06:1
LayoutMinimalPerf.default 688 654 1.05:1
Slider.Fluent 1445 1380 1.05:1
ButtonSlotsPerf.default 581 561 1.04:1
TableMinimalPerf.default 558 536 1.04:1
Text.Fluent 265 254 1.04:1
AnimationMinimalPerf.default 466 454 1.03:1
ChatWithPopoverPerf.default 522 508 1.03:1
DropdownManyItemsPerf.default 414 401 1.03:1
StatusMinimalPerf.default 235 229 1.03:1
CheckboxMinimalPerf.default 3655 3591 1.02:1
HierarchicalTreeMinimalPerf.default 843 826 1.02:1
LabelMinimalPerf.default 1040 1020 1.02:1
ListNestedPerf.default 731 715 1.02:1
PortalMinimalPerf.default 235 231 1.02:1
SplitButtonMinimalPerf.default 11447 11231 1.02:1
CustomToolbarPrototype.default 3561 3484 1.02:1
Dropdown.Fluent 3283 3232 1.02:1
MenuMinimalPerf.default 1983 1962 1.01:1
RadioGroupMinimalPerf.default 410 405 1.01:1
TreeWith60ListItems.default 230 228 1.01:1
DividerMinimalPerf.default 858 854 1:1
DropdownMinimalPerf.default 3361 3367 1:1
EmbedMinimalPerf.default 6154 6162 1:1
GridMinimalPerf.default 818 815 1:1
ListMinimalPerf.default 391 390 1:1
ToolbarMinimalPerf.default 818 815 1:1
AlertMinimalPerf.default 535 541 0.99:1
DialogMinimalPerf.default 1630 1647 0.99:1
ProviderMinimalPerf.default 571 575 0.99:1
ReactionMinimalPerf.default 2604 2622 0.99:1
AvatarMinimalPerf.default 490 502 0.98:1
CarouselMinimalPerf.default 1986 2027 0.98:1
FlexMinimalPerf.default 351 359 0.98:1
ListCommonPerf.default 904 925 0.98:1
FormMinimalPerf.default 701 724 0.97:1
TextAreaMinimalPerf.default 2765 2850 0.97:1
TooltipMinimalPerf.default 658 679 0.97:1
VideoMinimalPerf.default 644 662 0.97:1
ButtonMinimalPerf.default 109 114 0.96:1
ChatMinimalPerf.default 441 458 0.96:1
LoaderMinimalPerf.default 2477 2585 0.96:1
IconMinimalPerf.default 297 315 0.94:1
MenuButtonMinimalPerf.default 1439 1536 0.94:1
Checkbox.Fluent 746 792 0.94:1
AttachmentMinimalPerf.default 871 934 0.93:1
TreeMinimalPerf.default 849 920 0.92:1
ProviderMergeThemesPerf.default 1152 1263 0.91:1
Image.Fluent 229 252 0.91:1
AttachmentSlotsPerf.default 3126 3468 0.9:1
SegmentMinimalPerf.default 1362 1515 0.9:1
ListWith60ListItems.default 170 190 0.89:1
Button.Fluent 101 118 0.86:1
ItemLayoutMinimalPerf.default 1702 2084 0.82:1

Generated by 🚫 dangerJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codepretty codepretty Awaiting requested review from codepretty

@notandrew notandrew Awaiting requested review from notandrew

@bcalvery bcalvery Awaiting requested review from bcalvery

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345 ecraig12345 is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore JasonGore is a code owner

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@kenotron kenotron Awaiting requested review from kenotron

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanelVari @DustyTheBot