Proto/multi dropdown #334
Proto/multi dropdown #334
Conversation
354be54 to
33512c9
Compare
docs/src/prototypes/ChatPeoplePicker/ChatPeoplePickerExample.tsx
Outdated
Show resolved
Hide resolved
| </li> | ||
| <li>Open/Close dropdown on click and keyboard Enter/Up/Down/Esc.</li> | ||
| <li>Provide a callback for handling the selection of an element from the list.</li> | ||
| <li>Append aria roles and other attributes to make it accessible with screen reader.</li> |
docs/src/prototypes/ChatPeoplePicker/ChatPeoplePickerExample.tsx
Outdated
Show resolved
Hide resolved
src/components/Input/Input.tsx
Outdated
| const inputClasses = classes.input | ||
|
|
||
| return ( | ||
| <ElementType className={classes.root} onChange={onChange} {...rest}> |
There was a problem hiding this comment.
note that for onChange event here we are not providing the callback's signature that is advertised in prop types (namely, (e, props) => ...): here we are not providing any component's props to the callback
src/components/Input/Input.tsx
Outdated
| ref: this.handleInputRef, | ||
| }, | ||
| })} | ||
| {this.computeIcon() && |
There was a problem hiding this comment.
note, renderIcon support is lost with suggested changes. The same applies to renderInput
There was a problem hiding this comment.
We can iterate again on the Input once the new PR for it is merged, and can see if there is any other issues. This are just temporary fixes anyway.
1d7118b to
250ceea
Compare
docs/src/prototypes/ChatPeoplePicker/ChatPeoplePickerExample.tsx
Outdated
Show resolved
Hide resolved
docs/src/prototypes/ChatPeoplePicker/ChatPeoplePickerExample.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 89.94% 89.95% +<.01%
==========================================
Files 64 64
Lines 1253 1254 +1
Branches 162 162
==========================================
+ Hits 1127 1128 +1
Misses 123 123
Partials 3 3
Continue to review full report at Codecov.
|
|
@silviuavram Note, if you slightly adjust the PR description then this PR will automatically close the associated issue once it is merged. See here: https://help.github.com/articles/closing-issues-using-keywords Associated issue is #388 |
| {this.state.message} | ||
| </span> | ||
| {this.renderSelected()} | ||
| <Input |
There was a problem hiding this comment.
this Input element can be wrapped by Ref that is now exported from Stardust - no need to change Input component's API in that case
|
This PR preceded the Dropdown component, by having this prototype as reference. closing as the Dropdown component has been implemented. |
This PR contains the changes from #244 since it became pretty complicated to rebase master changes. Will update on its progress.
Do not merge yet! It still contains a work-around for Input in order to pass
role="presentation"to its<div>so the other Input examples are at the moment broken.