This repository was archived by the owner on Mar 4, 2020. It is now read-only.
test: remove console spy in tests #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
approved these changes
Oct 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 64 64
Lines 1259 1259
Branches 182 159 -23
=======================================
Hits 1130 1130
Misses 126 126
Partials 3 3Continue to review full report at Codecov.
|
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was intended to prevent improper usage of components in tests. React propTypes throws warnings when props are used incorrectly at runtime. We wanted to catch those and prevent our tests from improper usage.
The outcome is that actual console errors are improperly reported by jest since they are caught
afterAll. For now, we'd rather see the actual console messages. We can consider better ways to catch propType issues later.