Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Feat/multi dropdown component #422

Merged
merged 87 commits into from
Dec 10, 2018
Merged

Feat/multi dropdown component #422

merged 87 commits into from
Dec 10, 2018

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Nov 2, 2018 •
edited
Loading

Focus on creating the multiple pick dropdown.

Issue: #388

@silviuaavram silviuaavram force-pushed the feat/multi-dropdown-component branch from 7eb5e3a to 1d6cd1f Compare November 5, 2018 10:10
@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b6450d4). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #422   +/-   ##
========================================
  Coverage          ?   80.1%           
========================================
  Files             ?      46           
  Lines             ?    1749           
  Branches          ?     243           
========================================
  Hits              ?    1401           
  Misses            ?     343           
  Partials          ?       5
Impacted Files Coverage Δ
src/components/List/List.tsx 61.66% <ø> (ø)
src/components/Slot/Slot.tsx 100% <100%> (ø)
src/index.ts 100% <100%> (ø)
src/components/Dropdown/Dropdown.tsx 33.33% <33.33%> (ø)
src/components/Dropdown/DropdownLabel.tsx 39.39% <39.39%> (ø)
src/components/Dropdown/DropdownSearchInput.tsx 51.72% <51.72%> (ø)
src/components/Dropdown/DropdownItem.tsx 65.21% <65.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6450d4...d854fc7. Read the comment docs.

miroslavstastny
miroslavstastny reviewed Nov 8, 2018
View reviewed changes
@miroslavstastny
Copy link
Member

It also drops down under code editor in docsite:
image

@silviuaavram silviuaavram self-assigned this Nov 8, 2018
@joheredi joheredi mentioned this pull request Nov 9, 2018
Closed
This was referenced Nov 13, 2018
Open
Closed
@silviuaavram silviuaavram force-pushed the feat/multi-dropdown-component branch 2 times, most recently from 017a177 to 3f2b0ad Compare November 19, 2018 14:31
@bmdalex
Copy link
Collaborator

bmdalex commented Dec 6, 2018

any idea why this is happening in the screener tests?

https://screener.io/v2/states/rkGqtccHX.stardust-ui-react/feat%2Fmulti-dropdown-component/1024x768/Chrome/inputexampleinputslotshorthandtsx-0

@silviuaavram silviuaavram force-pushed the feat/multi-dropdown-component branch from edc35a2 to 359fea1 Compare December 8, 2018 15:57
@kuzhelov kuzhelov closed this Dec 10, 2018
@kuzhelov kuzhelov reopened this Dec 10, 2018
@kuzhelov kuzhelov dismissed bmdalex’s stale review December 10, 2018 01:58

seems that currently all issues that were raised are addressed

@kuzhelov kuzhelov merged commit d9648ed into master Dec 10, 2018
@layershifter layershifter deleted the feat/multi-dropdown-component branch January 10, 2019 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mnajdova mnajdova mnajdova left review comments

@bmdalex bmdalex bmdalex left review comments

@sophieH29 sophieH29 sophieH29 left review comments

@miroslavstastny miroslavstastny miroslavstastny left review comments

@jurokapsiar jurokapsiar jurokapsiar left review comments

@kuzhelov kuzhelov kuzhelov approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

Assignees

@silviuaavram silviuaavram

Labels
🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@silviuaavram @miroslavstastny @bmdalex @mnajdova @sophieH29 @kuzhelov @jurokapsiar @kuzhelov-ms