Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(lodash): add types and fix errors #438

Merged
merged 4 commits into from
Nov 15, 2018
Merged

fix(lodash): add types and fix errors #438

merged 4 commits into from
Nov 15, 2018

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Nov 6, 2018

Fix for adding lodash types. Closes #420

levithomason
levithomason reviewed Nov 7, 2018
View reviewed changes
levithomason
levithomason reviewed Nov 7, 2018
View reviewed changes
@levithomason levithomason added needs author feedback Author's opinion is asked needs author changes Author needs to implement changes before merge and removed 🚧 WIP labels Nov 7, 2018
@bmdalex bmdalex force-pushed the fix/lodash-types branch 2 times, most recently from 8e42568 to aeb71d2 Compare November 8, 2018 16:28
@codecov
Copy link

codecov bot commented Nov 8, 2018 •
edited
Loading

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          41       41           
  Lines        1432     1432           
  Branches      206      181   -25     
=======================================
  Hits         1267     1267           
  Misses        161      161           
  Partials        4        4
Impacted Files Coverage Δ
src/components/Popup/Popup.tsx 30.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dfefe...4fdef94. Read the comment docs.

@bmdalex bmdalex force-pushed the fix/lodash-types branch 2 times, most recently from 7da3788 to beaadfc Compare November 8, 2018 16:51
@bmdalex bmdalex added 🚀 ready for review and removed needs author feedback Author's opinion is asked needs author changes Author needs to implement changes before merge labels Nov 8, 2018
@bmdalex bmdalex force-pushed the fix/lodash-types branch 2 times, most recently from 5ccc733 to 3bf1f17 Compare November 8, 2018 17:42
kuzhelov
kuzhelov reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have left several minor comments - overall looks very good to me 👍 Please, consider to review changes made for the sorting procedure for dataMock - have some doubts there.

One thing that really raises concerns is that we have to use key as .. for docs examples - while the goal is to avoid any TS artifacts from these snippets. At the same time, should emphasize that this is definitely not the problem of this PR, but rather is a broader issue.

Thanks!

@bmdalex
Copy link
Collaborator Author

bmdalex commented Nov 12, 2018

@levithomason @layershifter @kuzhelov
ready again, can you take another look?

@bmdalex bmdalex self-assigned this Nov 13, 2018
@bmdalex bmdalex merged commit ff3daeb into master Nov 15, 2018
@bmdalex bmdalex deleted the fix/lodash-types branch November 15, 2018 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levithomason levithomason levithomason left review comments

@layershifter layershifter layershifter left review comments

@kuzhelov kuzhelov kuzhelov approved these changes

@silviuaavram silviuaavram silviuaavram approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@bmdalex bmdalex

Labels
🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmdalex @levithomason @kuzhelov @silviuaavram @layershifter