This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
listRef
prop ofList
component has lead to the problem described in #453 (and is a blocker for this PR to be merged).Reasons to remove
listRef
Proposed changes eliminate this prop from
List
API for the following reasons:ref
cannot be applied in cases whenElementType
is evaluated intoReact.SFC
component (this is, actually, what tests were warn about)ref
may reference component instance (and will reference DOM element only for string components likeul
, which luckily was the common case forList
):How to cover cases where
listRef
was supposed to be used?Cases that this
listRef
prop was aimed to cover now can be safely and easily covered withRef
component being exported from Stardust:No changes to the
List
API are necessary for that.